Add kex integration test for ed25519 server key#924
Open
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Add kex integration test for ed25519 server key#924yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Ed25519 host-key coverage to the integration KEX test flow by introducing sample Ed25519 server keys and teaching echoserver to load/use them.
Changes:
- Added an Ed25519 host-key integration test in
tests/kex.c. - Added Ed25519 server key material (
.der/.pem) underkeys/. - Updated
examples/echoserver/echoserver.c(and embedded cert buffers) to load the Ed25519 private key.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
wolfssh/certs_test.h |
Adds embedded Ed25519 DER key buffer for NO_FILESYSTEM builds. |
tests/kex.c |
Adds Ed25519 host-key test and adjusts test availability macros. |
keys/server-key-ed25519.pem |
Adds sample Ed25519 private key (PEM). |
keys/server-key-ed25519.der |
Adds sample Ed25519 private key (DER). |
examples/echoserver/echoserver.c |
Adds Ed25519 key loading logic and registers it with the server context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds kex integration test and sample keys for ed25519 use-case.
Also, this updates echoserver to load the ed25519 keys.