Name Constraints cert chain walk#10687
Open
rlm2002 wants to merge 2 commits into
Open
Conversation
|
retest this please |
|
…r cert Add to Signer struct to retrieve AKID data in NC cert walk
95ec6df to
4c99169
Compare
Contributor
Author
|
Retest this please Jenkins: PRB-fips-repo-and-harness-test-v3-part2 failure |
…st logic add same DN test
4c99169 to
f6e930f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements chain walk to perform Name Constraints check for certificate ancestors.
Walks the cert chain in
ParseCertRelativeand applies each ancestor CA's name constraints to the leaf. Previously only the immediate signer's constraints were checked, so higher-level CA constraints were not enforced.Parent lookup prefers AKID→SKID (validated against issuer name) and falls back to name-only; NO_SKID builds are name-only and cannot disambiguate same-DN sibling CAs in the CM.
Adds
authKeyIdHash+authKeyIdSettoSigner(populated inFillSignerfrom the cert's AKID) so the walk can locate each ancestor's parent by SKID viaGetCA, rather than relying on issuer name alone.Adds regression tests and supporting cert chain under
certs/test/nc-ancestor/.Fixes zd#21877, #21879, #21895
Testing
./configure --enable-all && make checkChecklist