.github: link parallel-make-check.py annotations to the workflow file#10700
Open
julek-wolfssl wants to merge 1 commit into
Open
.github: link parallel-make-check.py annotations to the workflow file#10700julek-wolfssl wants to merge 1 commit into
julek-wolfssl wants to merge 1 commit into
Conversation
A ::warning::/::error:: emitted with no file= property is pinned by GitHub to the .github directory, whose blob URL is a directory listing - so the stale-"minutes" annotations rendered with a dead source link and a line number that points at nothing. Derive the workflow file path from GITHUB_WORKFLOW_REF (owner/repo/path@ref) and pass it as file= so the annotations link to the real workflow that embeds the config list. Falls back to the previous fileless form off-CI or when the ref is unavailable.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves GitHub Actions annotations emitted by .github/scripts/parallel-make-check.py by attaching a file= property to ::warning:: / ::error:: workflow commands. This ensures annotation source links point to the actual workflow file (instead of the .github/ directory listing) by deriving the workflow path from GITHUB_WORKFLOW_REF, with a safe fallback to the previous fileless form when unavailable.
Changes:
- Add workflow-command property escaping (
gh_prop) and derive a workflowfile=property fromGITHUB_WORKFLOW_REF. - Emit
::warning file=…::and::error file=…::on GitHub Actions so annotations link to the workflow YAML.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
::warning::/::error::workflow command emitted with nofile=property is pinned by GitHub to the
.githubdirectory, whose blob URL is adirectory listing — so the annotations from
parallel-make-check.pyrendered with a dead source link and a line number that points at nothing.
Derive the workflow file path from
GITHUB_WORKFLOW_REF(
owner/repo/path@ref) and pass it asfile=so the annotations link to thereal workflow that embeds the config list. Falls back to the previous
fileless form off-CI or when the ref is unavailable.