Rust wrapper: validate WOLFSSL_PREFIX in build.rs#10703
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Rust wrapper’s build script handling of the WOLFSSL_PREFIX environment variable, aiming to avoid misconfiguration and reduce risk from malformed values when locating wolfSSL headers/libs.
Changes:
- Adds a helper to read/validate
WOLFSSL_PREFIX(currently rejecting newline-containing values). - Validates that
${WOLFSSL_PREFIX}/libexists before using it for linking; otherwise falls back to system/in-tree behavior. - Routes both include-dir and lib-dir selection through the same prefix helper for consistent behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
holtrop-wolfssl
force-pushed
the
rust-validate-prefix-env-var
branch
from
568e901 to
d523e46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check that WOLFSSL_PREFIX/lib directory exists if WOLFSSL_PREFIX is specified.
Check that WOLFSSL_PREFIX environment variable does not contain a newline character.
Testing
Build and run unit tests for Rust wrapper.
Checklist