fix(server): align organization access control type#296
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
onequery-landing | 01e5a08 | Commit Preview URL Branch Preview URL |
Jun 26 2026, 02:18 AM |
27675be to
01e5a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-Line Summary
OneQuery auth typechecks cleanly when consumed from Velen’s workspace type graph.
User-Facing Changes
@velen/web:typecheckfailing onorganization({ ac })type compatibility.Why This Changed
Velen typechecks vendored OneQuery source through a different workspace graph than OneQuery’s own CI. The precise
createAccessControl(...)generic is accepted by OneQuery directly, but Velen’s fresh affected typecheck reported it as incompatible with Better Auth’s plugin option shape.How It Changed
acoption type fromParameters<typeof organization>[0].organizationAccessControlto that option type before passing it toorganization(...).Bug Fixes
@velen/web:typecheckonvendor/onequery/packages/server/src/auth.ts.Verification
bunx turbo typecheck --json --filter=@onequery/server --filter=@velen/web --forcebun run --cwd vendor/onequery/packages/server vitest run src/services/data-source-query/validate-sql.test.tsbun run formatVideo / Screenshot (Optional)