enforce v3 verification levels and add health - #235
Draft
soamdesai-tfh wants to merge 14 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…health-pr # Conflicts: # sidecar/src/routes.rs
|
You must have Developer access to commit code to Tools For Humanity on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verification_levelinstead of silently defaulting to Orb.credential_unavailableand add a simulator/api/healthendpoint.Why
The v3 simulator path could report success when the active identity did not actually have the requested credential proof. The request-level
verification_levelwas ignored in parts of the flow,ModalConfirmreset the presented credential to Orb, andgetMerkleProofsilently returned dummy proof data when inclusion proof state was missing.Validation
./node_modules/.bin/tsc --noEmit --emitDeclarationOnly false --declaration false./node_modules/.bin/next lint(passes with existing Tailwind classname warnings)./node_modules/.bin/prettier --check src/**curl -sS -i http://localhost:3010/api/healthreturnedHTTP/1.1 200 OKwith{"ok":true}