Skip to content

Fix PHPCS errors in Behat test files #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
Sep 1, 2026
+9 −9
Merged

Fix PHPCS errors in Behat test files #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ceb1e6
Fix PHPCS errors in Behat test files
swissspidy Sep 1, 2026
5c29d21
Keep the unordered placeholders the tests are about
swissspidy Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/audit.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Feature: Audit strings in a WordPress project
* Text Domain: foo-plugin
*/

__( 'Hello %s %s', 'foo-plugin' );
__( 'Hello %s %s', 'foo-plugin' ); // phpcs:ignore WordPress.WP.I18n.UnorderedPlaceholdersText -- Unordered on purpose, this is what the audit is expected to flag.
"""

When I try `wp i18n audit foo-plugin`
Expand Down
16 changes: 8 additions & 8 deletions features/makepot.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -893,8 +893,8 @@ Feature: Generate a POT file of a WordPress project
*/

sprintf(
_n( 'One Comment', '%s Comments', $number, 'foo-plugin' ),
$number
_n( 'One Comment', '%s Comments', $number, 'foo-plugin' ),
$number
);

"""
Expand All @@ -920,9 +920,9 @@ Feature: Generate a POT file of a WordPress project
*/

sprintf(
_n( '%1$s Comment (%2$d)', '%2$s Comments (%1$s)', $number, 'foo-plugin' ),
$number,
$another_variable
_n( '%1$s Comment (%2$d)', '%2$s Comments (%1$s)', $number, 'foo-plugin' ),
$number,
$another_variable
);

"""
Expand All @@ -948,9 +948,9 @@ Feature: Generate a POT file of a WordPress project
*/

sprintf(
__( 'Hello %s %s', 'foo-plugin' ),
$a_variable,
$another_variable
__( 'Hello %s %s', 'foo-plugin' ), // phpcs:ignore WordPress.WP.I18n.UnorderedPlaceholdersText -- Unordered on purpose, this is what make-pot is expected to warn about.
$a_variable,
$another_variable
);

"""
Expand Down