feat(gallery): preview each run's instrument on row hover - #8
Merged
Conversation
Hovering a leaderboard row on desktop shows a cropped screenshot of that run's keyboard. Every run places the instrument differently, so the crop is found in the DOM rather than hard-coded: locate the keyboard, then walk up to the painted chassis containing it, which drops the surrounding status text and page background. Thumbnails sit beside the preview build they were shot from, so the gallery derives the URL from previewPath with no new run.json field. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm bench thumbs [<run-id>]shoots each published preview and crops to the instrument. The crop is found in the DOM rather than hard-coded — locate the keyboard (the element with the most key-shaped children), then walk up to the painted chassis containing it — so the surrounding status text and page background are dropped. All ten runs resolve via key detection; there are painted-bounds and full-viewport fallbacks.previewPathand no field is added torun.json.Layout notes
The card is pointer-only (hidden below the 900px breakpoint), aligns its left edge with the table's, and is sized to stop just short of the phase-sector columns — so it can cover a neighbouring model name but never anyone's scores. It clears the hovered row entirely and flips below the row when that row is near the top of the viewport, so the tallest crop is never clipped.
Test plan
pnpm typecheck,pnpm lint,pnpm test(36/36)thumb.jpgrequests 200, no console errorsbench thumbsis a manual step, not wired intoseal— a newly published preview shows no card until it is run