This repository was archived by the owner on Jun 15, 2026. It is now read-only.
fix: rename explainQuery to unsafeExplainQuery, implement and use safeExplainQuery - #225
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 25, 2025
Merged
Merged
divyenduz
marked this pull request as ready for review
September 25, 2025 19:44
tsg
approved these changes
Sep 26, 2025
divyenduz
added a commit
that referenced
this pull request
Sep 26, 2025
divyenduz
enabled auto-merge
September 26, 2025 17:46
divyenduz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion #223
We already improved it in #224, this PR makes it more secure by
explainQuerytounsafeExplainQuerywhile the single query check and transaction wrapping is pretty secure already, there might be edge cases where a query escapes the designated boundaries. Therefore, we rename the tool tounsafeExplainQuerysafeExplainQuery, this operates onqueryIdand fetches the actual SQL frompg_stat_statementstable itself thereby eliminating the code path that can lead to any SQL injection. This is done in the following stacked PR Implement safe explain #226safeExplainQuerytool instead ofunsafeExplainQuery, to make it work, we had to additionally returnqueryIdfromgetSlowQueriestool in addition to the slow SQL query. This is done in the following stacked PR Use safe explain tool #227