Add enforceValueInOptions prop to Select - #4485
Draft
lbwexler wants to merge 1 commit into
Draft
Conversation
Opt-in prop that keeps a Select's value constrained to its current options: when either the value or the options list changes, any selected value not found in options is automatically removed - cleared to emptyValue (single) or filtered out of the array (multi, desktop). Replaces app-level reactions that manually reconcile selection against options. - Enforces on both triggers (options reload and value set/bind) via a reaction tracking both, so the invariant holds regardless of which side changed. - Throws if combined with enableCreate or queryFn, where values may legitimately fall outside options. Closes #4111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
enforceValueInOptionsprop to the desktop and mobileSelectcomponents, addressing #4111.When enabled, the control keeps its value constrained to the current
options: whenever either the value or the options list changes, any selected value not found inoptionsis automatically removed — cleared toemptyValuefor single selects, or filtered out of the array for multi (desktop). This replaces the app-level reactions teams write today to reconcile a selection against reloaded options.Notes
enableCreateorqueryFn, where values may legitimately fall outsideoptions.generateOptionFn.Closes #4111