Cube tester updates for tiered grid transaction handling - #890
Merged
Conversation
Companion to hoist-react #4588, which removes GridExperimentalFlags.deltaSort - Hoist now manages ag-Grid delta sorting automatically per transaction, so the A/B toggle no longer has anything to switch.
Switch applies a 5s streamingSortInterval live to the existing GridModel - the new hoist-react #4588 prop is read per-transaction and by its flush timer, so no grid rebuild is required.
Drive the update stream with a plain setInterval instead of Timer, whose 500ms floor blocks sub-second rates. Ticks that arrive while a prior update is still applying are skipped, matching Timer's non-overlapping behavior.
lbwexler
changed the title
Replaces the sort throttle control with Defer Factor and Delta Ratio selects driving the new deferredSortFactor and deltaSortRatio experimental flags, applied live to the running GridModel. Adds a sortFlush row to the grid diagnostics section reporting each managed re-sort's mode, pending count, and elapsed time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to xh/hoist-react#4588 (tiered ag-Grid transaction handling).
Delta Sorttoggle - that PR removesGridExperimentalFlags.deltaSort, with Hoist now managing ag-Grid delta sorting automatically per transaction, so the A/B toggle no longer has anything to switch.Throttle Sorttoggle, applying the newGridModel.streamingSortIntervalprop (at 5s) live to the running grid.setInterval, asTimer's 500ms floor blocks sub-second rates - overlapping ticks are skipped, matching priorTimerbehavior.The tester's other toggles (Projection Only, Reuse Records, Patch Records) and diagnostics panel are unchanged and were used to validate the hoist-react PR's results at 40k and 400k rows.