feat(acp): move codex-acp to 1.10.0 - #655
Open
Adam-Dalloul wants to merge 1 commit into
Open
Conversation
The pin is what selects the codex core. 1.8.0 depends on @openai/codex ^0.152.0, and caret on a 0.x pins the minor, so it resolves no higher than 0.152.1 and can never reach a 0.153 core. 1.10.0 depends on ^0.153.3, which is the one that lists gpt-6-astra. The adapter bundle itself names a single model, gpt-5.6-luna for TitleGenerator; every id the picker offers comes from the core underneath. Neither 1.9.0 nor 1.10.0 moves a surface codeg reads. sessionCapabilities is byte-identical to 1.8.0's, so supports_fork and the rest are unchanged, and the whole initialize delta across the two releases is one new agent capability (_meta.authStatus) plus a fourth name in the AIR array. 1.9.0 pushes _auth/status_update with no client capability gating it. codeg drops it on the unrecognized-ext-notification arm of maybe_emit_ext_notification, which is the tolerance that arm exists for. 1.10.0 emits async_task_spawned and async_task_state_update, neither of which can deserialize into agent-client-protocol-schema 0.11.7's SessionUpdate. They stay off the wire because the adapter gates its whole async-task manager on the AIR asyncTasks advertisement, and codeg sends Codex ["sessionFailure"] only. Also correct two comments asserting codex has no async-task code. It has one now, narrower than Claude's, and enabling it is a separate change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI shipped
gpt-6-astra, and the pinned adapter cannot offer it.The model list comes from the codex core the adapter depends on, not from the
adapter bundle (which names one model,
gpt-5.6-luna, for its titlegenerator). 1.8.0 depends on
@openai/codex ^0.152.0; caret on a0.xpinsthe minor, so that resolves no higher than 0.152.1 and can never reach a 0.153
core. 1.10.0 depends on
^0.153.3, which has the model.Probed both over ACP stdio. 1.10.0 answers
initializeand servessession/newwith the model config option listing:1.8.0 does not list
gpt-6-astraat all.Nothing else in 1.9.0 or 1.10.0 moves a surface codeg reads:
sessionCapabilitiesis byte-identical to 1.8.0's, and both of the new wiresurfaces stay inert (1.9.0's
_auth/status_updatelands on theunrecognized-ext-notification arm; 1.10.0's async-task variants are gated on an
AIR advertisement codeg does not send to Codex). Per-version analysis is in the
registry comment as usual, along with the two comments 1.10.0 invalidated.