Skip to content

Selective: move [branch] in core - #93

Merged
xvw merged 1 commit into
masterfrom
selective-branch-should-be-in-core
Feb 25, 2021
Merged

Selective: move [branch] in core#93
xvw merged 1 commit into
masterfrom
selective-branch-should-be-in-core

Conversation

@gr-im

@gr-im gr-im commented Feb 23, 2021

Copy link
Copy Markdown
Collaborator

As mentioned by @snowleopard (feel free to say if you don't want be ping anymore) here: snowleopard/selective#30 select can be express via branch (and vice versa). So this PR move branch into Selective.CORE and allows to use select path or branch path for Selective incarnation.

@gr-im gr-im added the enhancement New feature or request label Feb 23, 2021
@gr-im gr-im self-assigned this Feb 23, 2021

@xvw xvw left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snowleopard snowleopard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, although I have to admit that I'm getting lost in all of these conversion functors. Providing a lot of ways to instantiate selective functors brings convenience but also complexity.

@snowleopard

Copy link
Copy Markdown
Collaborator

As mentioned by @snowleopard (feel free to say if you don't want be ping anymore) here

@gr-im I don't mind to be pinged. Thanks for continuing to explore the design space of selective functors!

@gr-im

gr-im commented Feb 25, 2021

Copy link
Copy Markdown
Collaborator Author

@gr-im I don't mind to be pinged. Thanks for continuing to explore the design space of selective functors!

Thanks a lot. To be really honest, Selective as replaced my usage of ArrowChoice, no more point free and its lead to readable solution. So thanks to have pointed (and properly elaborated in a very enjoyable paper).

Looks fine to me, although I have to admit that I'm getting lost in all of these conversion functors. Providing a lot of ways to instantiate selective functors brings convenience but also complexity.

Yes, we differ from the Janestreet approach (which use [< Derived | Defined f]) and the lack of implicits and higher kinded types lead to some complexe functors gymnastic. When Preface will be public I guess that the "happy path" will always be choose instead of building a module block by block (using Via). So it introduce a lot of boilerplate for the library maintainer, but in my opinion, it introduce less boilerplate for the user.

Thanks a lot for your reviews.

@xvw
xvw merged commit 1f27201 into master Feb 25, 2021
@xvw
xvw deleted the selective-branch-should-be-in-core branch February 25, 2021 07:06
@snowleopard

Copy link
Copy Markdown
Collaborator

Thanks @gr-im, all sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants