fix(admin): state the security-posture lattice in the resource label - #588
Open
yzxcj797 wants to merge 1 commit into
Open
fix(admin): state the security-posture lattice in the resource label#588yzxcj797 wants to merge 1 commit into
yzxcj797 wants to merge 1 commit into
Conversation
The posture label claimed "narrower scopes may tighten it but cannot weaken it" as a blanket guarantee. The postures do not form a per-control lattice: strict does not retain auto's inbound screening, it swaps content screening for approval-gated tools, and an operator tightening a scope in response to a security concern could silently lose a control (yc-software#574). Spell out the actual lattice: auto = inbound screening, no tool approvals; strict = screening OFF, every tool approval-gated; dangerous = screening off. The org value remains a floor on mode ordering, the only guarantee that holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the "at minimum" ask of part 2 of #574 (the label fix; the posture-behavior design question is left to the maintainers).
The problem (from the issue's own analysis)
The admin resource for
security-posturelabeled the org value as a blanket guarantee: "narrower scopes may tighten it but cannot weaken it." But the postures do not form a per-control lattice —strictdoes not retainauto's inbound screening; it swaps content screening for approval-gated tools. An operator tightening a scope in response to a security concern could thereby silently lose a control, which the label explicitly promised could not happen.Fix
The label now states the actual lattice up front:
The org value remains a floor on mode ordering — the only guarantee the postures actually form.
All 20 tests in
test/admin-resources.test.ts+test/security-posture.test.tspass unchanged (no test asserts label text).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.