Skip to content

fix(ci): verify the provenance attestation landed after publishing #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yzxcj797 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): verify the provenance attestation landed after publishing #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/publish-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,18 @@ jobs:
else
npm publish --provenance --access public
fi
# The provenance flag only produces an attestation when the run's
# OIDC token satisfies npm's requirements; every other failure mode
# publishes cleanly WITHOUT one, silently downgrading trust for
# attestation-checking installers (aube/pnpm trust policies) — exactly
# the 0.1.5 incident (#591). Verify the attestation actually landed
# and fail loudly otherwise.
attestations=$(npm view "@yc-software/qm@$version" attestations --json 2>/dev/null || echo '[]')
if [ "$attestations" = 'null' ] || [ "$attestations" = '[]' ] || [ -z "$attestations" ]; then
echo "::error::@yc-software/qm@$version published without a provenance attestation; trust-checking installers will refuse or downgrade it. Check the run's id-token permission and republish a new version."
exit 1
fi
echo "@yc-software/qm@$version published with provenance attestation"
if [ "$version" = 0.1.5 ]; then
npm deprecate @yc-software/qm@1.0.5 "Published with an incorrect version number; use 0.1.5."
fi
Expand Down