Fix /bench-verify target dirs - #882
Open
jotabulacios wants to merge 5 commits into
Open
Conversation
jotabulacios
marked this pull request as ready for review
July 31, 2026 17:57
Oppen
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/bench-verifyreported #874 as failing to verify its own proof. It wasn't: the PR side ranmain's binary. Both ref worktrees shared one
HOST_TARGET_DIR, so cargo declared thesecond ref fresh (
Finishedin 0.06s) instead of building it. Main's prover has no DMAtable, the guest's DMA ecalls had nothing to prove them, and the bundle didn't verify.
Same bug #878 fixed for the guest target dir — except the guest side dies loudly and the
host side just measures the wrong binary.
Description
Fix: each ref gets its own host target dir (
${HOST_TARGET_DIR}_<sha8>), like #878 didfor the guest one. Costs ~25s per ref on the first build, warm after that. Pruned the same
way, and the old shared dir is swept once.