docs(prover): allow 6->2 step-marker transition on the continuation path - #883
Open
MauroToscano wants to merge 1 commit into
Open
docs(prover): allow 6->2 step-marker transition on the continuation path#883MauroToscano wants to merge 1 commit into
MauroToscano wants to merge 1 commit into
Conversation
The marker state machine documented on test_recursion_step_markers_observed_in_order only covers the monolithic verify path. Once the continuation verify paths emit STEP_AIRS_AND_BUS_BALANCE_DONE (per epoch in verify_epoch and once in verify_global, #855), 6->2 becomes a legitimate transition there. Note the distinction so the documented invariant isn't read as universal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_recursion_step_markers_observed_in_orderdefines the valid step-marker transitions as{1->2, 2->3, 3->4, 4->5, 5->6, 6->3}and states any other transition means the marker convention broke.STEP_AIRS_AND_BUS_BALANCE_DONEbefore each epoch'smulti_verify_views(continuation::verify_epoch) and once more before the global-memory verify (continuation::verify_global), making6->2a legitimate transition there.recursion-minguest, where the continuation markers never fire).Test plan