Skip to content

intent: target-reviewer-policy-delivery - #166

Merged
yihanzhu merged 1 commit into
mainfrom
ystack/intent/target-reviewer-policy-delivery
Aug 28, 2026
Merged

intent: target-reviewer-policy-delivery#166
yihanzhu merged 1 commit into
mainfrom
ystack/intent/target-reviewer-policy-delivery

Conversation

@yihanzhu

Copy link
Copy Markdown
Owner

G1 — accept target-reviewer policy delivery

This is the strict-subset follow-up from #163 and PR #164. It carries only the unresolved requirement recorded in #165: make the accepted exceptional-implementation and comment floor reliably visible to independent reviewers inside target repositories.

Outcome

  • One versioned, portable delivery path gives author, coder, and selected reviewer the same policy meaning.
  • Core policy never depends on Claude, Codex, GitHub, one instruction filename, or a vendor review format.
  • Delivered/generated forms are tied to one source of truth and exact provenance.
  • Missing, stale, drifted, incompatible, or candidate-controlled reviewer rules fail closed.
  • A PR that changes its own applicable reviewer instructions cannot use those candidate instructions to certify itself.
  • Qualification covers ystack and an unrelated target.

Dependency and rollout boundary

G2 waits for #164 to merge and pins its accepted policy source by exact commit/blob. A repo-native template or checked generated section may then proceed independently. If design selects portable contract, profile-resolution, or reviewer-adapter fields, G2 also waits for the accepted G2 artifacts from portable-core-contracts, portable-profile-resolution, and portable-adapter-contract-tests; implementation pins their G3 commits.

Live adapter/profile activation waits for control foundation, durable orchestrator, default-adapter qualification, and environment-specific evidence. General install/upgrade machinery remains in the target-packaging roadmap item.

This G1 does not choose target AGENTS.md, generated sections, packages, or adapter injection. It changes no live reviewer, profile, installer, target file, or PR #154.

Proof

Verified in a clean detached worktree at e9f51ab29722c927adbc3f0dbe05f501c90dd1a3:

  • Intent stage: only work/target-reviewer-policy-delivery/intent.md changed; all five required headings present.
  • Independent builder review: clean.
  • Independent Security/Compliance review: clean.
  • Independent scope/dependency/roadmap consistency review: clean after conditional rollout gates were added.
  • ShellCheck 0.11.0 over tracked scripts: passed.
  • Required-file structure check: structure ok.
  • North-star resolver: 74 passed, 0 failed.
  • North-star gate/consumer: 226 passed, 0 failed.
  • models.conf parser: 63 passed, 0 failed.
  • degraded Codex gate: 91 passed, 0 failed.
  • Remaining v2 test suites and rename gate: passed.

Merging this PR is G1 acceptance into design only. It does not approve an implementation or change any live target reviewer.

Closes #165

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying ystack with  Cloudflare Pages  Cloudflare Pages

Latest commit: e9f51ab
Status: ✅  Deploy successful!
Preview URL: https://17ae70e4.fabrica-6yx.pages.dev
Branch Preview URL: https://ystack-intent-target-reviewe.fabrica-6yx.pages.dev

View logs

@yihanzhu

Copy link
Copy Markdown
Owner Author

Codex reviewer (cross-vendor, read-only)

Reviewed-head: e9f51ab
Reviewed-base: dc05812
reviewer: operator-default @ high

Posted verbatim by codex-review.sh (codex exec review --json --base refs/codex-review/166-50737/base in an isolated temp worktree, sandbox forced read-only). Comments only — Codex never pushes, approves, or merges.

The new intent follows the repository's artifact-chain structure, keeps implementation deferred, and records the required dependencies and safety boundaries. No blocking correctness issue is present.

@yihanzhu
yihanzhu merged commit d3284c3 into main Aug 28, 2026
2 checks passed
@yihanzhu
yihanzhu deleted the ystack/intent/target-reviewer-policy-delivery branch August 28, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deliver the exception rule to target reviewers

1 participant