Merge with upstream#87
Open
Desdaemon wants to merge 214 commits into
Open
Conversation
…mespace "Player::Constants"
…ch is to be used by the engine detection (#3166)
…ne_File & Scene_Save
…atDelimiter" patches from experimental branch "PlayerLimits"
…s in Vanilla RPG_RT)
…PG_RT (Fix #3412)
…reground interpreter has been processed (Fix #2432 / #2932)
…'t be shown when screen shaking is applied (Fix #2607)
…n might create unnecessarily expensive copy
…ter the resource has been moved
… not scrolling horizontally
Main difference is the logic when opening the save. Also moved it to ManiacPatch file to reduce complexity in the interpreter code. Header cleanup (was necessary because of weird compile errors due to a Game_String include while moving code around) Fix #3069
…f the output Requested to configure output on televisions when the edges are not visible. Fix #3395
CMake: Fix Lint errors
Rewrite ControlGlobalSave
SDL2/3: Add option to configure overscan/underscan (screen scaling)
```
easyrpg-player/src/game_interpreter.cpp:4848:28: error: ‘RuntimePatches’ has not been declared
4848 | auto key = RuntimePatches::VirtualKeys::VirtualKeyToInputKey(key_id);
| ^~~~~~~~~~~~~~
```
Fix build on Arch
@Mimigris found some missing usecases for Process JSON command. One of them related to missing access to the root of a JSON, for things like `GetKeys("/")` This PR Introduces a helper to handle JSON path resolution, including root path ('/'), and refactors all relevant functions to use it. Improves consistency, reduces code duplication, and adds explicit handling for root object operations in GetValue, SetValue, RemoveValue, Contains, and related methods.
… Maniacs and range checks
…rning Pathfinder Command: fix GCC 15 -Wnonnull warning
Return an optional instead of casting -1 into an enum
…ands-extension Maniacs Patch Commands - Missing simple variable parameters support
Not sure if this is 100% correct but it "feels" at least closer to RPG2k3 now when testing. What matches: - With EncRate 1 you get a forced encounter (before it was 2) - With 2 a forced after 2 (before it was 3) Higher numbers are harder to test due to randomness involved. Fix #2903
Maniacs Patch - Save Image command
…Anson/markdownlint-cli2-action-23 CI: Bump DavidAnson/markdownlint-cli2-action from 22 to 23
* Add Maniac=2 flag documentation - Using the flag on a 2k game keeps the variable range to the one of a 2k game, so this description was incorrect - Add a small explanation as to what is the purpose of this command - Change the Maniac flag documentation to mention Maniac=[N] rather than Maniac=1 - Add DirectMenu documentation
Variables already return 0 when out of bounds
Fix issues reported by zoeontheloose + Undefined Behaviour in ControlSwitches
Encounter rate: Fix off-by-one error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.