feat(memory): add safe-point SessionBank budget governor - #357
Open
PhilipJohnBasile wants to merge 2 commits into
Open
feat(memory): add safe-point SessionBank budget governor#357PhilipJohnBasile wants to merge 2 commits into
PhilipJohnBasile wants to merge 2 commits into
Conversation
youssofal
force-pushed
the
main
branch
2 times, most recently
from
September 1, 2026 08:07
2382dfd to
8bc4d88
Compare
PhilipJohnBasile
force-pushed
the
feat/sessionbank-memory-governor
branch
from
September 1, 2026 13:09
bc6f9bc to
4adb2fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extracts the SessionBank memory governor from #336 as one reviewable system.
It adds an opt-in controller behind
MTPLX_MEMORY_GOVERNOR=1. The controller samples process memory, applies hysteresis to SessionBank budget changes, and mutates the bank only after acquiring the model lock nonblocking and confirming that foreground, scheduler, restore, commit, MTP, and postcommit work are idle. Sampling happens before the lock is acquired.Measurement
Command:
python3 scripts/bench_memory_governor.py --observe-iterations 200000 --apply-iterations 50000 --batches 40 --output docs/benchmarks/sessionbank-memory-governor-no-model-20260826.jsonApple Silicon arm64, Python 3.14.7:
This is a synthetic controller-overhead measurement. It does not load a model, import MLX, or simulate a live macOS memory-pressure event. The tracked JSON receipt includes the exact command, host, configuration, and SHA-256 hashes of the measured inputs.
Validation
A full Ruff run without the exclusion still reports the existing
last_history_roleF841 inmtplx/server/openai.py; the same failure reproduces on untouched upstream/main.Excluded from this PR