test(app): isolate composer view lookup to main actor - #372
Open
PhilipJohnBasile wants to merge 2 commits into
Open
test(app): isolate composer view lookup to main actor#372PhilipJohnBasile wants to merge 2 commits into
PhilipJohnBasile wants to merge 2 commits into
Conversation
youssofal
force-pushed
the
main
branch
2 times, most recently
from
September 1, 2026 08:07
2382dfd to
8bc4d88
Compare
Signed-off-by: Philip John Basile <PBasile@Basilecom.com>
PhilipJohnBasile
force-pushed
the
codex/fix-swift-mainactor-helper
branch
from
September 1, 2026 13:02
a7ba855 to
4a59fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix current-main Swift test compilation under Swift 6 actor isolation.
ComposerReturnToSendTests.firstTextView(in:)walks AppKit view state, so the helper must be main-actor isolated like its test class and call sites.Validation:
swift build: passedThis is the one-line prerequisite for the current-main DeepSeek app integration test run.
@youssofal, please review.