Skip to content

feat(app): remove downloaded models safely - #377

Open
PhilipJohnBasile wants to merge 2 commits into
youssofal:mainfrom
PhilipJohnBasile:codex/issue-374-remove-model
Open

feat(app): remove downloaded models safely#377
PhilipJohnBasile wants to merge 2 commits into
youssofal:mainfrom
PhilipJohnBasile:codex/issue-374-remove-model

Conversation

@PhilipJohnBasile

@PhilipJohnBasile PhilipJohnBasile commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #374.

The desktop model picker now offers a confirmed Remove action for installed models. Removal delegates to the existing mtplx remove JSON contract, then refreshes the picker and model-update state.

Safety boundaries:

  • only direct children of the managed MTPLX cache are removable
  • the selected model and active model transfers are protected
  • user-managed folders and cached symlinks do not get the app removal action
  • explicit CLI removal unlinks a cache symlink without following or deleting its external target
  • unexpected non-directory cache entries fail closed

The CLI removal command is now included in the README quick reference.

Validation:

  • full Python suite: exit 0, 4,377 tests collected
  • full Swift suite: 659 passed, 1 existing skip
  • focused removal tests: 34 Python and 6 Swift passed
  • real CLI temporary-cache removal smoke: passed
  • swift build, Ruff, and git diff --check: passed

@youssofal, please review.

@youssofal
youssofal force-pushed the main branch 2 times, most recently from 2382dfd to 8bc4d88 Compare September 1, 2026 08:07
Signed-off-by: Philip John Basile <PBasile@Basilecom.com>
@PhilipJohnBasile
PhilipJohnBasile force-pushed the codex/issue-374-remove-model branch from 0dd69ac to 7a997c8 Compare September 1, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to remove older models

1 participant