ZEP-0021: propose valuesFrom and pathing updates to Zarf values - #66
Open
Racer159 wants to merge 2 commits into
Open
ZEP-0021: propose valuesFrom and pathing updates to Zarf values#66Racer159 wants to merge 2 commits into
valuesFrom and pathing updates to Zarf values#66Racer159 wants to merge 2 commits into
Conversation
Signed-off-by: Wayne Starr <me@racer159.com>
Signed-off-by: Wayne Starr <me@racer159.com>
AustinAbro321
left a comment
AustinAbro321
left a comment
Member
There was a problem hiding this comment.
Thank you for the proposal. I like the problem statement of abstracting common actions use cases
| @@ -379,6 +445,8 @@ This feature will require a lot of design work to ensure that it has a solid use | |||
|
|
|||
| We could patch the existing Variables/Constants/Templates paradigm to align more with Helm paradigms but this would not address the other issues that exist with Variables/Constants/Templates. Features like `autoIndent` and `setVariables` have always been limiting to users and creating a new way to set values will allow us to design something that is more user friendly (especially since many Zarf users are also Helm users). | |||
Member
There was a problem hiding this comment.
What are your thoughts would be on a custom function similar to Helm lookup ?
Functionally, I think we could make it generally mirror this proposal, but it's hard for me to say if it makes the UX better or worse.
I do like that the same function would be exposed to actions/charts/manifests
| targetPath: .resources # this wins | ||
| ``` | ||
|
|
||
| Also, `charts` and `manifests` would accept an optional `valuesFrom` list. Each entry contains required `kind`, `jsonPath`, and `targetPath` fields, with optional `name`, `namespace`, and `enabledPath` fields. `kind` would use the same discovery behavior as cluster wait actions and could be fully qualified when needed. A named source performs a `GET`; omitting `name` performs a `LIST` and makes `.items` available to `jsonPath`. `jsonPath` is evaluated by `client-go` and is written without kubectl's outer braces. |
Member
There was a problem hiding this comment.
It's unclear to me how manifests will work in this design? Is the target path package values?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
valuesFromsyntax as well as updated pathing for existingsourcePathandtargetPaths.valuesFromand update pathing in Zarf Values #65