avoid a reload when the avx2 round spills a row - #55
Open
BobDu wants to merge 1 commit into
Open
Conversation
Signed-off-by: BobDu <i@bobdu.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
State fills all sixteen ymm registers, so the avx2 round has to spill a row to get a rotate scratch.
It does not have to reload it: displacing a row the commutative ops can read from the memory operand removes six register moves and twenty seven reloads from every block.
Benchmarks on idle AWS m6a.large (EPYC 7R13, Zen 3) and m4.large (Xeon E5-2686 v4, Broadwell), neither of which has avx512f, the repository's
BenchmarkBLAKE3, Go 1.26.5, benchstat n=20, against master at 3863282: