Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty huge swing, but I have to admit, I'm not that familiar with Python's standard practices.
I used the information about the API from the Swagger docs to try and fix this library, since the
do.pishock.comAPI has been taken offline.Testing locally, I was able to get my devices to respond as expected, but I can't really be sure if everything is 100% correct here.
I tried my best to fix all of the tests, but I couldn't get the CLI tests for the serial shockers to work, and I'm still not sure why. Feel free to touch up anything you think is necessary.