feat!: excise zcashd by removing the regchest test backend - #1197
Open
zancas wants to merge 1 commit into
Open
Conversation
The regchest cargo feature was the last functional zcashd path in the repository: its docker image ships zcashd, zcash-cli, and lightwalletd with no zebrad mode. This change removes the regchest_utils dependency, the regchest features on the rustandroid and rustios crates, the gated arms in the integration and e2e suites, and the workflow, package.json, and README references. Every test now provisions its network through zingolib_testutils scenarios, which launch a native zebrad validator and lightwalletd indexer via zcash_local_net — the path gating CI already ran. ADR 0001 records the decision and the plan for darkside to inherit the vacated feature-gated backend seam. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
looks good, even would be a good idea if we archive that repo: regchest, to declare we are not using it anymore... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zcashd is dead, and the last functional zcashd path in this repository was the
regchestcargo feature: an alternative arm in each integration and e2e test that launched thezingodevops/regchestdocker container, whose image shipszcashd,zcash-cli, andlightwalletdand has no zebrad mode. This pull request removes that integration entirely.Every test now provisions its network exclusively through the formerly-default arm:
zingolib_testutilsscenarios drivingzcash_local_netto launch a native zebrad validator and lightwalletd indexer. This is a 1:1 replacement of the zcashd-backed test paths with zebrad-backed ones — no test bodies changed, and it is the path the gating Android integration CI already ran (--features "ci", neverregchest).Concretely, the change removes the
regchest_utilsdependency from the workspace and both mobile crates, deletes theregchestfeature fromrustandroidandrustios, strips the regchest-gated launch and teardown blocks from all three test suites, drops the regchest and colima/docker scaffolding from the commented-out iOS integration workflow, unpinsregchest_utilsfrom the build workflows and thecargo:updateyarn script, and rewrites the README testing prerequisites to describe the real harness (nativezebradandlightwalletdresolved via$PATHorTEST_BINARIES_DIR, working on Linux and macOS). The old instructions pointed at arust/android/regtest/bin/directory that did not exist.The new
docs/adr/0001-excise-zcashd-and-regchest.mdrecords the decision, the rejected alternatives (porting regchest to zebrad, which amounts to rebuilding it; or shipping a dormant broken flag), and the consequence: the darkside harness later inherits the vacated feature-gated backend seam, while real-validator coverage remains the zebrad default arm's job.Verified with
cargo check --tests,cargo clippy --tests, andcargo fmton both crates; a repository-wide sweep finds no remaining references to zcashd, zcash-cli, or regchest outside the ADR.🤖 Generated with Claude Code