fix(android): make wallet saves durable across power loss - #1265
Open
0bkevin wants to merge 3 commits into
Open
Conversation
Author
|
Just trying to help :) it's a big diff but it addressed the entire problem. Let me know if this follow your actual standards 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1224.
Problem
Android closed each encrypted wallet write without syncing the file or its parent directory. The save path then deleted its recovery copy in the same session. A hard power loss could leave a torn target on disk and no recovery file.
An already-corrupt target also prevented the recovery screen from replacing it with a newly created or restored wallet.
Changes
*.write.tmpuntil a later startup decrypts and syncs the replacement.The encrypted format, filenames, native bridge API, dependencies, and iOS path remain unchanged.
Verification
Manual API 30 x86_64 emulator check during development:
The targeted Android JVM suite and release unit suite passed before the final unreadable-target follow-up. They were not rerun at the current head. Pull request CI will run the current branch.