chore(deps): move the zingolib pin to dev head - #1297
Open
zancas wants to merge 2 commits into
Open
Conversation
The zingolib dependency resolves through `branch = "dev"`, so the pin lives in the lockfiles rather than in the manifests. Both lockfiles now name ffd16c22, twenty commits ahead of 00950535. Two of those commits change zingo-netutils and carry a breaking marker. One gives a conduit dial the fetch it guards, which rewrites zingo-price so the wallet drives the source race and first_quote only picks the winner. The other prunes the reqwest features the fetch inherited. Neither reaches this repository's source. The lightclient's mixnet module is byte-identical across the two revisions, so update_current_price still returns MixnetPriceFetch and zec_price still reads its usd field. The nym-proxy-ffi crate resolves in its own workspace and its own lockfile, which cargo update on the main workspace never touches. It pins zingo-netutils and the patched rustls-platform-verifier at the same branch, and this change moves both. Both workspaces compile against the new revision with all targets enabled, and the sixty unit tests in the main workspace and the seven in nym-proxy-ffi pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The zingolib dependency resolves through
branch = "dev". The pin thereforelives in the lockfiles, not in the manifests. This change moves the pin to
zingolib
ffd16c22. That revision is twenty commits ahead of the previouspin,
00950535.The change touches two lockfiles. The
rust/nym-proxy-fficrate resolves inits own workspace, with its own lockfile. A
cargo updateon the mainworkspace never touches it. That crate pins
zingo-netutilsand the patchedrustls-platform-verifierat the same branch. Both move here.Why now
zingolib merged pull request 2719, "Make the conduit dial a proper guard".
That pull request also rewrites
zingo-price.Risk
Two commits in the range carry a breaking marker. Both change
zingo-netutils.8d5f9488gives a conduit dial the fetch it guards. The wallet now drivesthe price source race.
first_quotenow only picks the winner from theoutcomes.
acd5e540prunes the reqwest features that the fetch inherited.Neither commit reaches this repository's source. The lightclient mixnet
module is byte-identical across the two revisions.
update_current_pricestill returns
MixnetPriceFetch.zec_pricestill reads theusdfield.Verification
Static checks:
ffd16c22with all targets enabled.nym-proxy-ffipasses its 7 unit tests.Device test, on an
x86_64emulator at API 36:x86_64. TheprodDebugbuild installs, opens its wallet, and syncs mainnet to height 3456314. The
scan covers Sapling, Orchard, and Ironwood outputs.
betaDebugbuild creates a new wallet and syncs to the chain tip.packets under cover traffic, at an average delay of 20 ms.
Kraken, and Coinbase. Every source answers. The winning quote arrives about
0.7 seconds after the tap. The race drains in under 7 seconds.
$ 840.70for ZEC.The price path is the surface that pull request 2719 rewrote, so the device
test exercises the change rather than the pin alone.
🤖 Generated with Claude Code