New Feature swap op_return - #2417
Closed
juanky201271 wants to merge 12 commits into
Closed
Conversation
Member
|
Superseded by the owned-spend-pipeline arc: ADR 0010 (PR #2469) routes OP_RETURN through the in-tree proposal types, and the zcb-swap approach this branch took was abandoned with that decision. |
juanky201271
added a commit
that referenced
this pull request
Aug 15, 2026
Mayachain and THORChain read a swap's refund destination from the inbound transaction's origin. A shielded spend exposes none, so a deposit paid straight from a note leaves the protocol with nowhere to return a failed swap's funds. `route_via_ephemeral` sends an ordinary transparent recipient down the exposure step that TEX addresses already take: the value moves shielded -> wallet ephemeral t-addr -> vault, and the transaction that pays the vault now has an origin the wallet controls. The OP_RETURN memo naming the swap already rides that same exposure step, so both halves of what the protocols need arrive together. The flag stops at the plan layer. Nothing downstream distinguishes this from a TEX flow, because structurally it is one. Send-all and the fee-sizing probes stay single-hop: no vault reads their origin. The closed PR #2417 carried this as a parameter to a forked zcash_client_backend. The in-tree pipeline owns the ZIP 320 split, so it is a routing decision here instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: