fix(zingolib): constrain wallet reader & recovery, and add validation method - #2749
Open
dorianvp wants to merge 5 commits into
Open
fix(zingolib): constrain wallet reader & recovery, and add validation method#2749dorianvp wants to merge 5 commits into
dorianvp wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LightWallet::validate promises an io::Result whose error names the byte offset reached, but the read path it wraps carried seven expect() calls that panic on crafted-but-reachable inputs: a pre-32 birthday above u32::MAX, account ids with the hardened bit set in the unified key store and in both address maps, a hardened transparent address index, a version 35 file whose key store vector holds no account 0, and a stored min_confirmations of zero. Each site now returns an InvalidData error instead, and the three identical account id reads collapse into one read_account_id helper. Five regression tests craft minimal wallet prefixes that reach the five shallow sites and assert validate returns an error rather than aborting. The birthday and min_confirmations sites sit behind fields whose grammars are impractical to hand-craft, so they are fixed by the same mechanical transformation without dedicated fixtures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zancas
previously approved these changes
Aug 28, 2026
zancas
left a comment
zancas
left a comment
Member
There was a problem hiding this comment.
I particularly like the CountingReader pattern.
(re) running tests locally.
fix: return InvalidData instead of panicking on crafted wallet bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.