Add support for targeting win-arm64 - #443
Conversation
|
Unfortunately, building
Ironically, the arm64 build is fine. But we can't merge this while it breaks win-x64 builds. |
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #443 +/- ##
==========================================
- Coverage 59.79% 59.73% -0.07%
==========================================
Files 33 33
Lines 5412 5416 +4
==========================================
- Hits 3236 3235 -1
- Misses 2176 2181 +5 ☔ View full report in Codecov by Sentry. |
|
@AArnott is this still draft? It looks like a complete 1-line change that I'd be happy to merge |
|
In my testing, this fixes |
|
Also, it would make the PR more useful if it actually added a win-arm64 build to the CI to prove it works. |
|
Oh ya... the CI doesn't even test building win-x64 right now. That's why it doesn't catch the problem with this PR as-is. |
The `ring` crate doesn't natively support win-arm64 yet. But a fork adds that support [as described here][workaround]. [workaround]: briansmith/ring#1514 (comment)
|
@AArnott I see the |
|
The challenge with the latest version of |
|
jjyr/hdwallet#21 is one such upgrade that we're still waiting on. |
|
I'm going to close this PR in favor of a new ones that takes the non-hacky approach (just updating dependencies as they are available to get to ring 0.17.) |
The
ringcrate doesn't natively support win-arm64 yet. But a fork adds that support as described here.aarch64-pc-windows-msvc.x86_64-pc-windows-msvchasn't been broken.