Update dependencies toward ring 0.17 and aarch64-pc-windows-msvc targeting support - #675
Closed
AArnott wants to merge 2 commits into
Closed
Update dependencies toward ring 0.17 and aarch64-pc-windows-msvc targeting support#675AArnott wants to merge 2 commits into
AArnott wants to merge 2 commits into
Conversation
This is one of several steps to upgrading the `ring` transitive dependency for native targeting of `aarch64-pc-windows-msvc`.
Contributor
Author
|
@juanky201271 Do you think you could help with addressing the build break: As this break is evidently in generated code instead of code within the repo (if I'm reading the path correctly), I don't know what it'll take to fix this. |
4 tasks
Contributor
Well, sorry, but I have no idea. Maybe @AloeareV can help up... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dependencies are in the tree that depend on ring 0.16.20 and prevent compiling for
aarch64-pc-windows-msvc.By updating them all these, the only remaining path to 0.16.20 is through
hdwallet, which hasn't yet upgraded (jjyr/hdwallet#21).