Remove Announce Volume#56
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe ESPHome firmware version is updated, the public announcement volume entity is removed, and announcement playback no longer explicitly sets or restores volume. ChangesAnnouncement volume update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Integrations/ESPHome/Core.yaml (1)
392-393: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winRemove the incomplete
volume_setactions.These steps provide only
id; remove both entiremedia_player.volume_setactions so the device uses its existing media volume and the ESPHome config remains valid.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Integrations/ESPHome/Core.yaml` around lines 392 - 393, Remove both incomplete media_player.volume_set actions near the external_media_player definition, including their containing action blocks and id-only payloads. Leave the surrounding wait_until flow and existing media volume behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Integrations/ESPHome/Core.yaml`:
- Around line 392-393: Remove both incomplete media_player.volume_set actions
near the external_media_player definition, including their containing action
blocks and id-only payloads. Leave the surrounding wait_until flow and existing
media volume behavior unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 874d72a6-a297-4a2d-b9c0-126afc508ff1
📒 Files selected for processing (1)
Integrations/ESPHome/Core.yaml
|
@coderabbitai review |
✅ Action performedReview finished.
|
PR #56 removed the volume restore that was the only reader of current_volume, leaving the global and its assignment in on_announcement write-only. Drop both. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Version: 26.7.22.1
What does this implement/fix?
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit
New Features
Changes