Skip to content

Remove Announce Volume#56

Merged
TrevorSchirmer merged 3 commits into
betafrom
RemoveAnnounceVol
Jul 23, 2026
Merged

Remove Announce Volume#56
TrevorSchirmer merged 3 commits into
betafrom
RemoveAnnounceVol

Conversation

@TrevorSchirmer

@TrevorSchirmer TrevorSchirmer commented Jul 23, 2026

Copy link
Copy Markdown
Member

Version: 26.7.22.1

What does this implement/fix?

  • Removes announce volume. Just uses media volume

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • New Features

    • Updated the firmware version to 26.7.22.1.
  • Changes

    • Removed the configurable announcement volume control.
    • During announcements, volume behavior has changed: volume is no longer explicitly adjusted and restored automatically; announcement handling now relies on ducking transitions and timing based on the announcement state.

@github-actions github-actions Bot added the bugfix Something isn't working label Jul 23, 2026
@github-actions
github-actions Bot requested a review from bharvey88 July 23, 2026 02:19
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@bharvey88, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ffcbc87-2bd0-458b-b1e5-afd30b2b8686

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd638c and 632af8a.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

Walkthrough

The ESPHome firmware version is updated, the public announcement volume entity is removed, and announcement playback no longer explicitly sets or restores volume.

Changes

Announcement volume update

Layer / File(s) Summary
Announcement flow and firmware update
Integrations/ESPHome/Core.yaml
Updates the firmware version, removes Apollo CAST-1 Announce Volume, and adjusts announcement sequencing to use ducking transitions without explicit volume-setting actions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: bharvey88

Poem

I’m a rabbit with ears held high,
The volume slider hops goodbye.
Announcements follow their way,
With fresher firmware in the hay.
Hop, hop—cleaner sound today!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the separate announce volume control.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch RemoveAnnounceVol

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Integrations/ESPHome/Core.yaml (1)

392-393: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win

Remove the incomplete volume_set actions.

These steps provide only id; remove both entire media_player.volume_set actions so the device uses its existing media volume and the ESPHome config remains valid.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Integrations/ESPHome/Core.yaml` around lines 392 - 393, Remove both
incomplete media_player.volume_set actions near the external_media_player
definition, including their containing action blocks and id-only payloads. Leave
the surrounding wait_until flow and existing media volume behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@Integrations/ESPHome/Core.yaml`:
- Around line 392-393: Remove both incomplete media_player.volume_set actions
near the external_media_player definition, including their containing action
blocks and id-only payloads. Leave the surrounding wait_until flow and existing
media volume behavior unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 874d72a6-a297-4a2d-b9c0-126afc508ff1

📥 Commits

Reviewing files that changed from the base of the PR and between f74eeca and 0b06183.

📒 Files selected for processing (1)
  • Integrations/ESPHome/Core.yaml

@TrevorSchirmer

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

PR #56 removed the volume restore that was the only reader of
current_volume, leaving the global and its assignment in
on_announcement write-only. Drop both.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88 bharvey88 mentioned this pull request Jul 23, 2026
10 tasks
@TrevorSchirmer
TrevorSchirmer merged commit 4c8a6bf into beta Jul 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants