fix: restore Angular Components submenu interactions - #91
Open
Banegasn wants to merge 3 commits into
Open
Conversation
Owner
Author
|
Acceptance review found two P1 blockers:
Implementation has been returned for these focused fixes. |
Owner
Author
|
Addressed both P1s in 5d7d326.
Validated: m3-menu browser tests (24 across Chromium/Firefox/WebKit), m3-menu lint/typecheck/build; Angular unit tests, lint/typecheck/build, and Playwright e2e (2/2). Angular build retains its pre-existing budget warnings. |
Owner
Author
|
Re-review found two remaining P1 blockers:
Wrapper-slotted discovery, shadow-tree one-item/no-destination paths, and timer cleanup are accepted. |
Banegasn
force-pushed
the
codex/fix-angular-components-submenu
branch
from
July 30, 2026 08:01
20bc512 to
9fab7df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
On the Angular demo desktop rail, hover Components, then move through the positioning offset into the submenu. The previous implementation could dismiss before the pointer reached the overlay; the Components rail item also navigated immediately instead of acting as a submenu trigger, and keyboard activation did not establish an Escape return-focus target.
Fix
Validation
pnpm --filter @banegasn/m3-menu test(18 browser tests, including WebKit)pnpm --filter @banegasn/m3-menu lintpnpm --filter @banegasn/m3-menu typecheckpnpm --filter @apps/angular-app testpnpm --filter @apps/angular-app lintpnpm --filter @apps/angular-app typecheckpnpm --filter @apps/angular-app build