Skip to content

probe(ci): BLO-20869 — pre-fix baseline v2, force verify_serialized_server skipped, do not merge - #1008

Closed
allyblockcast[bot] wants to merge 1 commit into
masterfrom
probe/blo-20869-serialized-skip-baseline-v2
Closed

probe(ci): BLO-20869 — pre-fix baseline v2, force verify_serialized_server skipped, do not merge#1008
allyblockcast[bot] wants to merge 1 commit into
masterfrom
probe/blo-20869-serialized-skip-baseline-v2

Conversation

@allyblockcast

@allyblockcast allyblockcast Bot commented Aug 4, 2026

Copy link
Copy Markdown

Do not merge — throwaway probe, closing without merging once evidence is captured.

Rebased version of #959, which is stale against current master (BLO-20867/#964 landed a verify rewrite in between). Same probe: unmodified verify job (pre-BLO-20869-fix) + verify_serialized_server forced to skipped via if: false.

Expected reading once checks settle: verify still reports success (it doesn't check this lane today), so mergeable: MERGEABLE, mergeStateStatus: UNSTABLE/CLEAN — reproducing the defect from PR #911 on demand.

Tracking: https://paperclip.blockcast.net/BLO/issues/BLO-20869

…erver skipped, do not merge

Rebased onto current master (unmodified verify job) to get a clean,
non-conflicting mergeStateStatus reading for the still-open defect:
a skipped serialized shard should currently still leave verify green
and the PR MERGEABLE/UNSTABLE. Throwaway -- closing without merging
once the reading is captured.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@allyblockcast

allyblockcast Bot commented Aug 4, 2026

Copy link
Copy Markdown
Author

🔗 Paperclip issue: BLO-20867
🔗 Paperclip issue: BLO-20869

@allyblockcast

allyblockcast Bot commented Aug 4, 2026

Copy link
Copy Markdown
Author

Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention:

Missing or incomplete:

  • Missing section: ## Thinking Path
  • Missing section: ## What Changed
  • Missing section: ## Verification
  • Missing section: ## Risks
  • Missing section: ## Model Used
  • Add the dedup-search checkbox to your PR description and check it once you have searched the GitHub PR list for similar PRs. See the PR template at .github/PULL_REQUEST_TEMPLATE.md and CONTRIBUTING.md → "Before You Start: Search First".
  • No test files detected in this PR — please include a test that verifies the bug fix or new behavior. If this PR genuinely doesn't need a test (e.g. a refactor), please retitle with refactor: prefix.

Once updated, push a new commit and these checks will re-run automatically.

— commitperclip

@allyblockcast

allyblockcast Bot commented Aug 4, 2026

Copy link
Copy Markdown
Author

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: fd74c40

Looks good for the stated diagnostic probe. The forced skip at .github/workflows/pr.yml:513 is narrowly scoped, and the current verify job omits verify_serialized_server from its needs, so this change exercises the intended false-green baseline.

Suggestions (1)

  • [native-codex] .github/workflows/pr.yml:513 — Capture the expected check result, then close this PR without merging. Landing if: false would permanently suppress all serialized-server shards while leaving the umbrella verify check unable to observe them.

Strengths

  • The probe is minimal and clearly marked as non-production in both the PR metadata and inline comments.
  • No application code, secrets, permissions, SQL, dependencies, or untrusted-input boundaries change.
  • The exact-head workflow confirms the probe targets the missing dependency edge rather than altering unrelated CI behavior.

Recommended Action

  1. Record the expected verify_serialized_server=skipped and umbrella verify=success evidence once checks settle.
  2. Close this throwaway probe without merging.
  3. This PR is authored by app/allyblockcast; the exact head must be reopened under an independent author before an Ally App approval is possible. The shared merge-token user is not substitute gate evidence.

@kkroo

kkroo commented Aug 4, 2026

Copy link
Copy Markdown

Closing the throwaway BLO-20869 pre-fix probe per the PR body. Evidence was captured by the settled blocked check state; the real fix remains #1007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant