Skip to content

probe(ci): BLO-20869 — pre-fix baseline, force verify_serialized_server skipped, do not merge - #959

Closed
allyblockcast[bot] wants to merge 1 commit into
masterfrom
probe/blo-20869-serialized-skip-baseline
Closed

probe(ci): BLO-20869 — pre-fix baseline, force verify_serialized_server skipped, do not merge#959
allyblockcast[bot] wants to merge 1 commit into
masterfrom
probe/blo-20869-serialized-skip-baseline

Conversation

@allyblockcast

@allyblockcast allyblockcast Bot commented Aug 2, 2026

Copy link
Copy Markdown

Thinking Path

  • Paperclip is the open source app people use to manage AI agents for work
  • BLO-20869 reports that a cancelled/skipped/never-scheduled verify_serialized_server shard is invisible to the merge gate
  • This is the pre-fix baseline half of the probe in #958 — split into its own PR because pr.yml's concurrency: group: pr-${{ pr number }}, cancel-in-progress: true would have cancelled this run the moment the post-fix commit was pushed to the same PR
  • Forces verify_serialized_server to report skipped via if: false, using master's current (pre-fix) verify, which does not consume verify_serialized_server
  • Expect mergeable: MERGEABLE, mergeStateStatus: UNSTABLE despite the forced skip — the defect BLO-20869 describes
  • Not meant to be merged — will be closed once evidence is captured

This is a throwaway probe PR. Do not merge. It will be closed without merging once evidence is captured on BLO-20869.

Linked Issues or Issue Description

Refs: BLO-20869 — paired with #958 (post-fix half).

What Changed

  • .github/workflows/pr.yml: verify_serialized_server forced to if: false (skip) for probe purposes only. verify is unmodified (pre-fix).

Verification

Expect mergeStateStatus: UNSTABLE / mergeable: MERGEABLE on this commit despite the forced skip. Compare against #958's post-fix commit, expected BLOCKED. Both pasted on BLO-20869.

Risks

Zero production risk — throwaway probe branch, closed without merging.

Model Used

Claude Sonnet 5 (claude-sonnet-5[1m]), 1M context, standard tool use.

Checklist

  • I have included a thinking path that traces from project context to this change
  • I have specified the model used (with version and capability details)
  • I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work
  • I have searched GitHub for duplicate or related PRs and linked them above
  • I have either (a) linked existing issues with Fixes: # / Closes # / Refs # OR (b) described the issue in-PR following the relevant issue template
  • I have run tests locally and they pass (n/a — probe workflow change)
  • I have added or updated tests where applicable (n/a — throwaway probe)
  • If this change affects the UI, I have included before/after screenshots (n/a)
  • I have updated relevant documentation to reflect my changes (n/a)
  • I have considered and documented any risks above
  • All Paperclip CI gates are green (expected UNSTABLE by design)
  • Greptile is 5/5 with no open P2s, recommendations, or follow-ups (n/a — probe, not merged)
  • I will address all Greptile and reviewer comments before requesting merge (n/a — will not request merge)

@allyblockcast

allyblockcast Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

🔗 Paperclip issue: BLO-20869

1 similar comment
@allyblockcast

allyblockcast Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

🔗 Paperclip issue: BLO-20869

…eline)

BLO-20869 probe branch, not for merge. Forces the serialized-server
matrix job to report `skipped` via `if: false`, standing in for the
cancelled/skipped/never-scheduled cases the issue describes, without
waiting on a real 90-minute run or an ARC outage. Uses master's current
(pre-fix) `verify`, which does not consume verify_serialized_server, to
capture the pre-fix baseline: expect mergeable/UNSTABLE despite the
forced skip.

Split into its own branch/PR (distinct commit SHA) rather than reusing
#958's first commit, because that SHA's check-runs were contaminated by
cancellation when #958's concurrency group (pr-958, cancel-in-progress)
picked up the follow-up post-fix commit before the baseline run finished.

BLO-20869

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@allyblockcast
allyblockcast Bot force-pushed the probe/blo-20869-serialized-skip-baseline branch from c6d6f89 to 68a0609 Compare August 2, 2026 10:16
@allyblockcast

allyblockcast Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention:

Missing or incomplete:

  • No test files detected in this PR — please include a test that verifies the bug fix or new behavior. If this PR genuinely doesn't need a test (e.g. a refactor), please retitle with refactor: prefix.

Once updated, push a new commit and these checks will re-run automatically.

— commitperclip

1 similar comment
@allyblockcast

allyblockcast Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

Hey @allyblockcast[bot]! Before this PR can be reviewed, a few things need attention:

Missing or incomplete:

  • No test files detected in this PR — please include a test that verifies the bug fix or new behavior. If this PR genuinely doesn't need a test (e.g. a refactor), please retitle with refactor: prefix.

Once updated, push a new commit and these checks will re-run automatically.

— commitperclip

@allyblockcast

allyblockcast Bot commented Aug 2, 2026

Copy link
Copy Markdown
Author

Ally — Consolidated PR Review

Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Reviewed head: 68a0609

Important Issues (1)

  • [gstack/review + native-codex] .github/workflows/pr.yml:411 — The probe does not reliably produce the claimed skipped serialized job without waiting for general_tests. The job still declares needs: [policy, general_tests], so GitHub waits for those prerequisites before evaluating/instantiating the disabled matrix job. On this exact head, run 30743422885 cancelled the upstream lanes first; the serialized check then concluded cancelled, not skipped, and the PR currently reports mergeStateStatus: BEHIND rather than the expected UNSTABLE. This run therefore cannot serve as evidence for the skipped-job merge-gate baseline.
  • Recommendation: make the probe job independent of the long-running prerequisite (or add a separate minimal probe job/check with the exact required-check semantics), let it complete with a verified skipped conclusion, and capture the resulting merge state before closing the probe.

Strengths

  • The change is narrowly scoped, clearly marked as throwaway probe code, and documents the intended comparison with the post-fix PR.

Recommended Action

  1. Correct the probe dependency shape and rerun until the exact serialized check concludes skipped.
  2. Do not merge this throwaway probe.

Reviewer identity note: this PR is authored by app/allyblockcast, so the Ally GitHub App cannot review or approve its own PR. The exact head must be reopened under an independent author before an App approval can be possible; the shared merge-token user is not gate evidence.

@allyblockcast

allyblockcast Bot commented Aug 4, 2026

Copy link
Copy Markdown
Author

Superseded by #1008 — rebased onto current master to get a clean, non-conflicting mergeStateStatus reading.

@allyblockcast allyblockcast Bot closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants