node_cpu: document an invocation that runs - #99
Merged
Conversation
`python -m mote_bringup.tools.node_cpu` raises `ModuleNotFoundError: No module named 'mote_bringup.tools'`. `mote_bringup/tools/` has no `__init__.py`, so setup.py's `find_packages()` never picks it up -- deliberately, since these are harnesses run from a checkout and not code the robot installs. Every sibling tool documents the path form for that reason; node_cpu was the only one claiming otherwise, in its two usage examples and in the tuning run notes. Use `pixi run node-cpu`, which is the task this tool already ships with and the form camera_layer_decay documents (pixi appends trailing arguments, so `--summary`/`--nodes` pass straight through). Reported by review on #96. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6o6x5Nn7QYUMxg2F3Wy2t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #96, from its review.
python -m mote_bringup.tools.node_cpu— the formnode_cpu.py's own docstringgave — does not run:
mote_bringup/tools/has no__init__.py, sosetup.py'sfind_packages()never picks it up. That is deliberate: these are harnesses run from a checkout,
not code the robot installs, which is why every sibling tool (
slip_replay,icp_excursions,odom_health,icp_gate_replay,camera_layer_decay)documents the path form.
node_cpuwas the only one claiming otherwise, and thetool itself was always invoked correctly during the measurements — by path on the
Pi — so nothing exercised the documented form.
The review found two occurrences in
node_cpu.py; there were four. The samebroken form was in
docs/tuning/2026-08-11-monitor-cpu/runs.txt, and the tuningdoc carried a bare
mote_bringup/tools/node_cpu.py --summary <csv>, which is nota runnable command either.
All four now use
pixi run node-cpu— the task #96 already added, and the formcamera_layer_decaydocuments. Pixi appends trailing arguments, so--summary/--nodes/--durationpass straight through; verified byre-deriving the figures the tuning doc quotes:
The alternative fix — adding
mote_bringup/tools/__init__.pyso-mworks — wasrejected: it would make
find_packages()ship the tools into the install spaceand onto the robot, a packaging change nobody asked for, and would leave
node_cputhe odd one out among its siblings in the opposite direction.Docs only: 4 lines across 3 files, no behaviour change.
pre-commit run --all-filesclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01X6o6x5Nn7QYUMxg2F3Wy2t