Skip to content

[stack 36/39] Reap review agents on shutdown - #240

Draft
sarthakagrawal927 wants to merge 11 commits into
stack/20e-repository-docs-01from
stack/22-signal-cancellation
Draft

[stack 36/39] Reap review agents on shutdown#240
sarthakagrawal927 wants to merge 11 commits into
stack/20e-repository-docs-01from
stack/22-signal-cancellation

Conversation

@sarthakagrawal927

@sarthakagrawal927 sarthakagrawal927 commented Sep 2, 2026

Copy link
Copy Markdown
Member

Outcome

Closes the independent Claude review finding that native cancellation could terminate the Rust CLI parent while leaving its separately grouped Claude or Codex reviewer alive.

Changes

  • intercept Unix SIGINT and SIGTERM in the codevetter CLI
  • mark every review owned by the CLI process as cancelled
  • wait for the existing process-group kill and reap path before exiting
  • preserve conventional exit codes 130 and 143
  • add focused cancellation and signal-exit tests

Evidence

  • independent Claude Sonnet review: one high-severity cancellation finding, USD 2.06
  • cargo test --locked --features browser-agent: 1070 library + 35 CLI + 5 desktop + 1 MCP binary + 3 MCP stdio passed, 0 failed
  • focused process-shutdown and CLI signal tests passed
  • repository Biome and Gitleaks pre-push gates passed

Stack

Layer 36 of 38. Base: #238. Draft only. No merge, release, deployment, signing, notarization, or Tauri retirement is authorized before the owner approval gate.

…ellation

# Conflicts:
#	apps/desktop/src-tauri/src/codevetter_cli_tests.rs
@sarthakagrawal927
sarthakagrawal927 changed the base branch from stack/21-cli-test-module to stack/20e-repository-docs-01 September 2, 2026 17:48
@sarthakagrawal927 sarthakagrawal927 changed the title fix(cli): reap review agents on shutdown [37/37] fix(cli): reap review agents on shutdown [37/36] Sep 2, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@sarthakagrawal927 sarthakagrawal927 changed the title fix(cli): reap review agents on shutdown [37/36] [stack 36/37] Reap review agents on shutdown Sep 2, 2026
@sarthakagrawal927 sarthakagrawal927 changed the title [stack 36/37] Reap review agents on shutdown [stack 36/38] Reap review agents on shutdown Sep 2, 2026
@sarthakagrawal927 sarthakagrawal927 changed the title [stack 36/38] Reap review agents on shutdown [stack 36/39] Reap review agents on shutdown Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants