Let a ui profile carry the layout and theme it selects - #17
Merged
Conversation
Screenplay's `ui profile` can already say which application shell and which theme a target uses - `layout AppShell`, `theme Aurora` - but `UiProfile` had nowhere to put either, so Stage's translation dropped both and documented them as gaps. They belong here rather than on a screen. A screen that named its own shell or theme would stop being portable across targets, which is the whole reason profile selection exists. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
einari
added
screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
UiProfilegainedLayoutandTheme— the application shell a target renders inside, and the visual theme it applies. Screenplay'sui profilecould already state both (layout AppShell,theme Aurora), but the model had nowhere to hold them, so translation dropped them.Both belong on the profile rather than on a screen: a screen that named its own shell or theme would stop being portable across targets, which is the reason profile selection exists at all.
🤖 Generated with Claude Code