Skip to content

Add movies and TV show search bar to app shell#3

Open
CyberoniOntoni wants to merge 5 commits into
feature/xbox-controllerfrom
feature/shell-search
Open

Add movies and TV show search bar to app shell#3
CyberoniOntoni wants to merge 5 commits into
feature/xbox-controllerfrom
feature/shell-search

Conversation

@CyberoniOntoni

Copy link
Copy Markdown
Owner

Summary

Adds a persistent movies/TV search bar to the app shell, plus stability fixes for AutoSuggestBox and search-to-details navigation. Builds on the Xbox controller PR.

Search

  • Styled AutoSuggestBox in MainPage with debounced Jellyfin search hints
  • Submitting a query navigates to a dedicated Search results page with portrait cards
  • Picking a suggestion navigates to item details

Crash fixes

  • Replace fragile TwoWay x:Bind on search text with code-behind handling
  • Remove TextMemberPath (requires WinRT-bindable custom properties)
  • Suppress duplicate navigation after SuggestionChosen
  • Cancel stale ItemDetails loads; guard null UserData on series items
  • Defer suggestion navigation to the next UI frame; log unhandled exceptions

Merge order

Stacks on the Xbox controller PR (base: feature/xbox-controller). Merge dfederm#88 → controller PR → this PR.

Part of splitting the former dfederm#89 into bite-sized reviews.

Test plan

  • Search bar accepts keyboard and controller input
  • Debounced hints show movies and TV shows
  • Submit opens search results page
  • Selecting a suggestion opens item details without crash
  • Verified on Xbox Series X (dev mode)

Place a styled AutoSuggestBox at the top of MainPage with debounced Jellyfin search hints. Submitting a query or picking a suggestion navigates to search results or item details. Includes a dedicated Search page with portrait result cards and adjusted content page spacing for the new header.
Replace nested TwoWay x:Bind on search text with code-behind TextChanged handling, use ObservableCollection for suggestions with TextMemberPath, simplify the search box style, and restore full-screen navigation overlay span.
Suppress duplicate QuerySubmitted navigation after SuggestionChosen, cancel stale ItemDetails loads when navigating away, and guard against null UserData on series items.
Defer AutoSuggestBox suggestion navigation to the next UI frame, reset ItemDetails playback state between loads, use null-safe stream bindings, navigate cards by item id, and log unhandled exceptions to the debug output.
AutoSuggestBox TextMemberPath requires WinRT bindable custom properties on suggestion items. Selection text is already applied in code when a suggestion is chosen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant