Build fixes, Xbox controller support, and movie/TV search#89
Closed
CyberoniOntoni wants to merge 8 commits into
Closed
Build fixes, Xbox controller support, and movie/TV search#89CyberoniOntoni wants to merge 8 commits into
CyberoniOntoni wants to merge 8 commits into
Conversation
Build/restore: pin Directory.Packages.props path for Visual Studio CPM discovery; pin Microsoft.Kiota.* to 1.22.0 (fixes NU1903); harden SetAppxManifestVersion with explicit manifest path and BuildVersion fallback. Playback: prefer direct play without subtitle index when client-side rendering is supported; load only the selected external subtitle; download external subtitles with Jellyfin auth via CreateFromStream; cache bitrate test per session; reduce subtitle presentation churn.
Centralize gamepad virtual-key handling in GamepadInput and route shell navigation (menu toggle, left-edge open, B/Escape back) through NavigationManager at the CoreWindow level so it works on every content page, not only when MainPage has focus. Video playback now maps A to play/pause, X to mute, and D-pad/stick directions to volume and seeking. Login and server selection accept Gamepad A to submit. WebVideo supports B to go back.
Place a styled AutoSuggestBox at the top of MainPage with debounced Jellyfin search hints. Submitting a query or picking a suggestion navigates to search results or item details. Includes a dedicated Search page with portrait result cards and adjusted content page spacing for the new header.
Replace nested TwoWay x:Bind on search text with code-behind TextChanged handling, use ObservableCollection for suggestions with TextMemberPath, simplify the search box style, and restore full-screen navigation overlay span.
Suppress duplicate QuerySubmitted navigation after SuggestionChosen, cancel stale ItemDetails loads when navigating away, and guard against null UserData on series items.
Defer AutoSuggestBox suggestion navigation to the next UI frame, reset ItemDetails playback state between loads, use null-safe stream bindings, navigate cards by item id, and log unhandled exceptions to the debug output.
AutoSuggestBox TextMemberPath requires WinRT bindable custom properties on suggestion items. Selection text is already applied in code when a suggestion is chosen.
Route Home page collection tiles through the same navigation path as the side menu so Movies, TV Shows, Collections, and Books open the library view instead of item details. Add CollectionNavigation to map Jellyfin collection types to library parameters. Introduce ShellFocusCoordinator so search is not focused by default and navigation no longer calls the invalid FocusState.Unfocused API on Xbox. Move library filter toolbar XYFocus bindings to code-behind for console stability. Target Xbox in the app manifest (min OS 22000, JellyBox.exe entry for AOT) and add a win-x64 publish profile for Release sideload builds.
dfederm
requested changes
Jun 19, 2026
dfederm
left a comment
dfederm
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution! I only really skimmed the changes for now as it's over 1000 lines to look at and intertwined with your changes in #88. Tease these apart in to separate PRs so I can review them independently in bite-sized chunks.
|
|
||
| SystemNavigationManager.GetForCurrentView().BackRequested += BackRequested; | ||
| Window.Current.CoreWindow.Dispatcher.AcceleratorKeyActivated += AcceleratorKeyActivated; | ||
| Window.Current.CoreWindow.KeyDown += CoreWindowKeyDown; |
Owner
There was a problem hiding this comment.
This is event registration is never removed and collides with full-screen players. Both the Video and WebVideo pages register their own CoreWindow.KeyDown, so during playback both fire.
| // TODO: Some kind of error message. Or genericize the collection view. | ||
| } | ||
| else | ||
| if (CollectionNavigation.TryCreateLibraryParameters(item, out Library.Parameters libraryParameters)) |
Owner
There was a problem hiding this comment.
Unmapped collections (Music, etc) now map to ItemDetails instead of no-op'ing. Likely that's a broken details page for those, so this should either preserve the old no-op behavior or I'd like to see that the experience is at least non-broken (doesn't need to be optimized; a nop isn't great either but is is non-broken).
| /// <summary> | ||
| /// Automatically focuses the first item in a list once items are loaded and containers are realized. | ||
| /// </summary> | ||
| #pragma warning disable CA1812 // Instantiated via XAML Interaction.Behaviors. |
Owner
There was a problem hiding this comment.
I'm not seeing these warnings. Can you explain?
| ImageHeight = imageHeight, | ||
| Image = image, | ||
| NavigateCommand = new RelayCommand(() => _navigationManager.NavigateToItem(item)), | ||
| NavigateCommand = item.Type == BaseItemDto_Type.CollectionFolder |
Owner
There was a problem hiding this comment.
This branch is redundant. You can always just pass the full item.
| public void NavigateToItem(Guid itemId) | ||
| { | ||
| CurrentItem = itemId; | ||
| NavigateContentFrame<ItemDetails>(new ItemDetails.Parameters(itemId)); |
Owner
There was a problem hiding this comment.
This seems pretty brittle. What if the item is a collection?
This was referenced Jun 20, 2026
Closed
Contributor
Author
|
Split per your feedback — closing this monolithic PR in favor of bite-sized, ordered reviews. Upstream PR stack (merge in order)
Bite-sized diffs (fork stacked PRs)If you prefer reviewing only the incremental diff for each step:
Sorry for the large combined diff — happy to adjust the split further if you'd like a different grouping. |
Contributor
Author
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves JellyBox build reliability, subtitle playback, Xbox Series X/S controller navigation, shell-level search, and library browsing on console.
It includes the work from #88 plus additional controller, search, and navigation features.
Build and restore (VS 2026 / CPM)
DirectoryPackagesPropsPathwin-x64.pubxmlpublish profile for Native AOT Xbox sideload buildsJellyBox.exeentry point for AOT packagesSubtitle playback
Xbox controller and navigation
GamepadInputand handle shell navigation at the CoreWindow levelShellFocusCoordinatorso search is not auto-focused; fix invalidFocusState.Unfocusedcrash on navigationSearch
Library navigation
NavigateToItem(BaseItemDto))CollectionNavigationmapping for Movies, TV Shows, Collections (box sets), and BooksTest plan
Notes