Skip to content

test(firmware): add LOS-31 golden replay scenarios - #339

Merged
LostPointer merged 5 commits into
developfrom
lostpointmeister/los-31-fw-s23-scenario-replay-asserts-on-golden-episodes-tilt
Aug 18, 2026
Merged

test(firmware): add LOS-31 golden replay scenarios#339
LostPointer merged 5 commits into
developfrom
lostpointmeister/los-31-fw-s23-scenario-replay-asserts-on-golden-episodes-tilt

Conversation

@LostPointer

@LostPointer LostPointer commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What changed

  • add five real-data golden replay scenarios for tilt, failsafe, oversteer, straight driving, and reverse steering
  • extend the telemetry loader with explicit RC/Wi-Fi source-presence fields
  • let batch replay restore drive mode, stabilization, and recorded oversteer thresholds
  • add a reproducible fixture extractor and detailed provenance for every episode
  • cover the sim-host oversteer override with a host unit test

Why

LOS-31 requires behavioral regressions on representative ride episodes, beyond the generic replay invariants introduced by FW-S2.2. These tests turn the previously observed tilt-heading, failsafe, oversteer, straight-course, and reverse-steering behaviors into deterministic host regressions without hardware.

The original telemetry does not contain RC/Wi-Fi presence flags, so the failsafe fixture uses real stationary sensor data with explicitly reconstructed source absence. The oversteer fixture restores the configuration captured in the source ride; both reconstructions are documented in the fixture provenance.

Validation

  • ctest --output-on-failure: 1104 passed
  • python -m pytest -q in firmware/sim: 94 passed, 1 skipped
  • LOS-31 scenario suite: 5 passed
  • git diff --check: clean

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e22fd09482

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread projects/rc_vehicle/firmware/sim/tests/test_scenario_replay.py Outdated
@LostPointer
LostPointer force-pushed the lostpointmeister/los-31-fw-s23-scenario-replay-asserts-on-golden-episodes-tilt branch from e22fd09 to 923171b Compare August 17, 2026 23:00

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 923171b5e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread projects/rc_vehicle/firmware/sim/tests/fixtures/rides/extract_real_golden.py Outdated
Comment thread projects/rc_vehicle/firmware/sim/tests/test_scenario_replay.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: abd5bc44f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread projects/rc_vehicle/firmware/sim/tests/test_scenario_replay.py Outdated
Comment thread projects/rc_vehicle/firmware/sim/tests/test_scenario_replay.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2d893906d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread projects/rc_vehicle/firmware/sim/tests/test_scenario_replay.py Outdated
@LostPointer
LostPointer merged commit f9ceea7 into develop Aug 18, 2026
10 checks passed
@LostPointer
LostPointer deleted the lostpointmeister/los-31-fw-s23-scenario-replay-asserts-on-golden-episodes-tilt branch August 18, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant