feat(security): warn when SMB_ADDRESS uses plaintext http to a remote host - #303
Open
birme wants to merge 1 commit into
Open
feat(security): warn when SMB_ADDRESS uses plaintext http to a remote host#303birme wants to merge 1 commit into
birme wants to merge 1 commit into
Conversation
… host Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/server.tsnow parsesSMB_ADDRESSand, if the scheme ishttp:and the hostname is not localhost/127.0.0.1/::1, emits aLog().warn(...)explaining that SDP/ICE data would be sent unencrypted and to usehttps://in production.SMB_ADDRESSlogs a warning instead of crashing startup.Test plan
npm run typecheckcleannpm testall pass (243 tests; the "worker process failed to exit gracefully" warning is a pre-existing timer-leak notice, not a failure)npm run lintclean forsrc/server.tsSMB_ADDRESS=http://remote-host:8080and confirm the warning appears; confirm no warning forhttp://localhost:8080orhttps://...Closes #276