Skip to content

feat(security): warn when SMB_ADDRESS uses plaintext http to a remote host - #303

Open
birme wants to merge 1 commit into
mainfrom
security/276-smb-plaintext-warning
Open

feat(security): warn when SMB_ADDRESS uses plaintext http to a remote host#303
birme wants to merge 1 commit into
mainfrom
security/276-smb-plaintext-warning

Conversation

@birme

@birme birme commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • At startup, src/server.ts now parses SMB_ADDRESS and, if the scheme is http: and the hostname is not localhost/127.0.0.1/::1, emits a Log().warn(...) explaining that SDP/ICE data would be sent unencrypted and to use https:// in production.
  • Parsing is wrapped in a try/catch so a malformed SMB_ADDRESS logs a warning instead of crashing startup.
  • Warning-only behavior: never a hard failure.

Test plan

  • npm run typecheck clean
  • npm test all pass (243 tests; the "worker process failed to exit gracefully" warning is a pre-existing timer-leak notice, not a failure)
  • npm run lint clean for src/server.ts
  • Manual: start with SMB_ADDRESS=http://remote-host:8080 and confirm the warning appears; confirm no warning for http://localhost:8080 or https://...

Closes #276

… host

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: Warn at startup when SMB_ADDRESS uses plaintext http:// to a non-localhost host

2 participants