Skip to content

feat(security): warn when SMB_ADDRESS uses plaintext http to a remote host #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
birme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(security): warn when SMB_ADDRESS uses plaintext http to a remote host #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ if (!process.env.SMB_ADDRESS) {
Log().warn('SMB_ADDRESS environment variable not set, using defaults');
}

try {
const smbUrl = new URL(SMB_ADDRESS);
const localHosts = ['localhost', '127.0.0.1', '::1'];
if (smbUrl.protocol === 'http:' && !localHosts.includes(smbUrl.hostname)) {
Log().warn(
`SMB_ADDRESS uses plaintext http:// to a remote host (${smbUrl.hostname}); SDP/ICE data will be sent unencrypted. Use https:// in production.`
);
}
} catch (err) {
Log().warn(`SMB_ADDRESS could not be parsed as a URL: ${SMB_ADDRESS}`);
}

const ENDPOINT_IDLE_TIMEOUT_S: string =
process.env.ENDPOINT_IDLE_TIMEOUT_S ?? '60';

Expand Down
Loading