Docs: Check-in Post locks in place; Weekly/Mentor Summaries never delete - #51
Merged
Merged
Conversation
…r deleted Grilling session for the message-delete bug (thread replies orphaned on delete). Slack bot tokens can never delete another user's message, and Attendance Notes are already durably captured in SQLite at reply-time, so deletion was never load-bearing anywhere. ADR-0013/0014.
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONTEXT.mdupdated: Event Check-in Post, Reaction Cutoff, Reaction Cutoff Verification, Event Attendance Report, Weekly Summary Post, Informational Reply, Mentor/Teacher Weekly Summary.Both decisions come from investigating #50 (the message-delete/orphaned-thread-replies bug): a Slack bot token can never delete a message someone else posted, so cascade-deleting a thread was never fully achievable. The design instead eliminates deletion entirely — a full fix with no permission gap to work around.
The implementation lands in a separate PR (#feat/checkin-lock-and-summary-retention → this branch), per this repo's convention of keeping domain docs and code on separate branches/PRs.
Test plan