Lock Check-in Post instead of deleting; stop deleting Weekly/Mentor Summaries - #53
Merged
Conversation
…ummaries Implements #50: Reaction Cutoff now edits the Check-in Post in place (lockCheckinPost) rather than deleting it, and postDueWeeklySummary / postDueMentorSummary no longer delete the previous cycle's post. The now-unused deleteWeeklySummary helper is removed. See ADR-0013/0014.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rehomes the implementation from #52, which merged into
docs/checkin-lock-and-summary-retentionafter that branch's own PR (#51) had already merged intomain— so the code never actually landed. Content is byte-identical to what #52 merged (verified diff-for-diff); this just targetsmaindirectly.lockCheckinPost) instead of deleted.postDueWeeklySummary/postDueMentorSummaryno longer delete the previous cycle's post before posting a new one.deleteWeeklySummaryhelper.Closes #50.
Test plan
npm run typechecknpm test(203 passing)npm run format:checknpm run build