fix: bump CommonLibSSE-NG to 6.6.3 for Skyrim 1.7.99 - #7
Open
rrasto wants to merge 1 commit into
Open
Conversation
4.38.0 cannot run on Skyrim 1.7.99. That release is the first to move the minor version from 6 to 7, which older builds classify as SE and then look for a version-1-7-99-0.bin that does not exist, and it ships the Address Library in format 5, which they cannot parse. Both were fixed upstream in 6.4.0, and 6.6.1 through 6.6.3 add further 1.7.99 corrections. No source changes were needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extern/CommonLibSSEis pinned to CommonLibSSE-NG 4.38.0, which cannot run on Skyrim 1.7.99.Two independent reasons, both already fixed upstream:
minor == 6to AE, so they classify 1.7.99 as SE and look forversion-1-7-99-0.bin, whichdoes not exist.
direct-indexed offset array). A parser for it arrived in 6.4.0.
Without this, FLICK stops at load with:
This bumps the submodule to 6.6.3. 6.6.1 through 6.6.3 are all 1.7.99 correctness fixes,
including
RUNTIME_DATAoffsets and the MapMenu/LocalMapMenu layout, so 6.6.0 alone is notenough for a UI framework.
No source changes were needed. The diff is the submodule pointer and nothing else.
What I verified before opening this:
x64-windows-static).versionlib-1-7-99-0.bin:77226resolves to0x1007910,68617to0xCF9390.E8, the near call thatstl::write_thunk_callexpects:0x1007910 + 0x275(Renderer) and0xCF9390 + 0x7B(Hooks).enable, and the menu opens and renders in game.