[GFX-722] 修复加载失败场景仍被标记已加载的字典缺陷 - #2
Conversation
Linear: GFX-722
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changes场景加载状态处理
Estimated code review effort: 1 (简单) | ~5 minutes Merge Risk: ⚪ Minimal · up to Failed scene loads are no longer recorded as loaded, while successful loading behavior and public APIs remain unchanged. The change is localized and merge-ready after normal checks, with no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
## [2.3.2](2.3.1...2.3.2) (2026-08-28) ### Bug Fixes * **scene:** 修复加载失败场景仍被标记已加载的字典缺陷 ([#2](#2)) ([b77ebc1](b77ebc1))
Linear: GFX-722
变更
Runtime/Scene/Scene/GameSceneManager.cs:OnLoadSceneCompleted状态判定前置——前置计算loadSucceed = IsDone && Status == Succeed,仅成功时把句柄写入m_LoadedSceneAssetNames,成功/失败回调分支复用同一判定。UnloadScene不再对失败句柄走异常分支、同名场景重试不再被 "already loaded" 拦截、失败地址/句柄不再泄漏在字典中。value == null防御分支仍登记成功句柄);公共 API 无变化。验证
UtilityCS0103,源于本机引用集取自核心包未合并的 Utility 重构检出),零新增错误。SceneIsLoaded == false、SceneIsLoading == false,同名场景可立即重试;UnloadScene按 "not loaded yet" 正确抛错。SceneIsLoaded为 false。关联
Fixes GFX-722
Summary by CodeRabbit