Skip to content

Report staging update and sign-in failures safely - #126

Merged
bermanto merged 1 commit into
mainfrom
fix/staging-status-diagnostics
Sep 7, 2026
Merged

Report staging update and sign-in failures safely#126
bermanto merged 1 commit into
mainfrom
fix/staging-status-diagnostics

Conversation

@bermanto

@bermanto bermanto commented Sep 7, 2026

Copy link
Copy Markdown
Member

The public upgrade gate stopped with a same-version repair error even during a version upgrade. Report which of the five strict status checks failed as booleans, without logging response values. The checks remain unchanged.

The channel E2E test now sends the same explicit origin as the other staging sign-in tests and includes the HTTP status when sign-in fails. This makes the two failures in public run 34142366293 actionable.

Validation: full local check passed (946 unit tests, 216 integration tests, coverage, architecture, and build); deployment dry run passed. A fresh public upgrade run will verify both paths after merge. No product behavior, signed archive, or schema changes.

Summary by CodeRabbit

  • Bug Fixes
    • Improved update-check error reporting. When an update probe fails, the message now provides clearer details about the installed version, candidate version availability, compatibility, and repair status.
    • This makes staging update issues easier to understand and troubleshoot than the previous generic error message.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 45d83096-1ee8-4491-8445-6252b6c4875a

📥 Commits

Reviewing files that changed from the base of the PR and between b9b3f53 and c9f3287.

📒 Files selected for processing (2)
  • scripts/release/staging-update-gate.mjs
  • test/e2e/staging/update-channel.spec.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The staging update probe now reports structured validation details. The staging end-to-end test sends the staging origin during owner sign-in and includes the HTTP status in assertion failures.

Changes

Staging update flow

Layer / File(s) Summary
Structured probe failure status
scripts/release/staging-update-gate.mjs
Probe failures now serialize installed version, candidate version, availability, compatibility, and repair status.
Staging sign-in request context
test/e2e/staging/update-channel.spec.ts
The owner sign-in request sends the staging origin. The sign-in assertion reports the returned HTTP status on failure.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to c9f32

This improves staging upgrade and sign-in failure diagnostics without changing product behavior, authentication behavior, schemas, or release artifacts. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the change summary, validation results, and notes. It does not use the template headings or checklist format, but it provides the required information.
Title check ✅ Passed The title is concise and accurately summarizes the staging failure diagnostics for update and sign-in flows.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/staging-status-diagnostics

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bermanto
bermanto merged commit bc39fdf into main Sep 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant