Skip to content

Report staging update and sign-in failures safely #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bermanto merged 1 commit into from
Sep 7, 2026
Merged

Report staging update and sign-in failures safely #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion scripts/release/staging-update-gate.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,18 @@ export async function probeStagingUpdateGate(options = {}) {
status.compatible !== true ||
status.repairRequired !== !context.publicUpgrade
) {
throw new Error("The deployed candidate did not report the expected same-version repair.");
const checks = {
installedVersion:
status.installedVersion ===
(context.publicUpgrade ? context.sourceVersion : context.candidateVersion),
candidateVersion: status.release?.version === context.candidateVersion,
available: status.available === true,
compatible: status.compatible === true,
repairRequired: status.repairRequired === !context.publicUpgrade
};
throw new Error(
`The deployed update status did not match the gate: ${JSON.stringify(checks)}.`
);
}

manifest.releaseGate.workersBuild.dispatchStartedAt = new Date().toISOString();
Expand Down
5 changes: 3 additions & 2 deletions test/e2e/staging/update-channel.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ test("owner can leave Nightly without changing the installed release", async ({
email: process.env.HQBASE_STAGING_OWNER_EMAIL,
password: process.env.HQBASE_STAGING_OWNER_PASSWORD,
rememberMe: false
}
},
headers: { origin: new URL(process.env.HQBASE_STAGING_URL!).origin }
});
expect(login.ok()).toBeTruthy();
expect(login.ok(), `Owner sign-in returned HTTP ${login.status()}.`).toBeTruthy();
const before = await (await request.get("/api/health")).json();
try {
await page.goto("/settings/updates");
Expand Down